Fix #5276: improve the media location access dialog strings #5368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the sequence of displaying dialogues
Member
|
Sorry for getting to this PR a bit late, @1911-revo. It seems the app's code has changed a lot during the meantime and is causing conflicts. Could you take a look and handle the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the sequence of displaying dialogues
Description (required)
Fixes #5276
I modified some codes in NearbyParentFragment.java, including two functions: checkPermissionsAndPerformAction and locationPermissionLauncher. By this modification, the app can show the developers' defined dialog block before the Android pre-defined location access dialog block.
Tests performed (required)
Tested ProdDebug on Oppo Reno 8 with API level 13.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.
